Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adopting new PyData sphinx theme #2093

Closed
mwaskom opened this issue May 23, 2020 · 4 comments · Fixed by #2842
Closed

Consider adopting new PyData sphinx theme #2093

mwaskom opened this issue May 23, 2020 · 4 comments · Fixed by #2842
Labels
docs
Milestone
v0.12.0

Comments

@mwaskom
Copy link
Owner

mwaskom commented May 23, 2020

https://github.com/pandas-dev/pydata-sphinx-theme
@mwaskom mwaskom added the docs label May 23, 2020
@mwaskom mwaskom added this to the v0.11.0 milestone May 23, 2020
@mwaskom
Copy link
Owner Author

mwaskom commented Jun 4, 2020

Blocking issue upstream: pydata/pydata-sphinx-theme#146

@Anselmoo
Copy link

Anselmoo commented Aug 4, 2020

Dear @mwaskom ,

if you consider updating the doc theme, can you please take look on the search engine.

For not listed items, the docs are searching forever.

For example: Searching for title on seaborn

  1. will not stop searching after 10min or more
  2. will not show any results

Maybe it's caused to an older version of mkdocs??

@mwaskom
Copy link
Owner Author

mwaskom commented Aug 4, 2020

Theme is unrelated to search engine. I don't know what's happening there. I also don't know what mkdocs is. seaborn uses sphinx.

@mwaskom
Copy link
Owner Author

mwaskom commented Aug 4, 2020

xref sphinx-doc/sphinx#6244

@mwaskom mwaskom modified the milestones: v0.11.0, v0.12.0 Aug 30, 2020
@mwaskom mwaskom mentioned this issue Nov 26, 2021
Closed
@mwaskom mwaskom mentioned this issue Jun 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging a pull request may close this issue.

Convert docs to pydata-sphinx-theme and add new material mwaskom/seaborn
2 participants
@mwaskom @Anselmoo