Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider golangci-lint integration? #69

Closed
twpayne opened this issue May 8, 2020 · 3 comments
Closed

consider golangci-lint integration? #69

twpayne opened this issue May 8, 2020 · 3 comments

Comments

@twpayne
Copy link
Contributor

twpayne commented May 8, 2020

github.com/golangci/golangci-lint includes a gofmt linter that verifies that code is formatted with gofmt (code).

Would you consider a similar integration for gofumpt into golangci-lint?

Note that this would address some of #28 by association as fixed versions of gofumpt would be bundled inside golangci-lint releases.

@mvdan
Copy link
Owner

mvdan commented May 8, 2020

Sure, why not - but wouldn't that be work on their end? If you're asking about making my code available, note that it's already exposed via https://pkg.go.dev/mvdan.cc/gofumpt/format as of a few days ago.

@gonzaloserrano
Copy link
Sponsor Contributor

It has just been merged golangci/golangci-lint#1177

@mvdan
Copy link
Owner

mvdan commented Jun 16, 2020

Great - I'll consider this done :)

@mvdan mvdan closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants