Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grunt cssmin task is removing the pixel fallbacks for rem units #18

Closed
willmcl opened this issue Sep 16, 2014 · 2 comments
Closed

Grunt cssmin task is removing the pixel fallbacks for rem units #18

willmcl opened this issue Sep 16, 2014 · 2 comments
Assignees
Labels
Milestone

Comments

@willmcl
Copy link
Contributor

willmcl commented Sep 16, 2014

We need to remove the mixin and just run grunt-pixrem after minification as there is no option in the cssmin task to avoid this. see here

@k33 k33 self-assigned this Sep 19, 2014
@willmcl
Copy link
Contributor Author

willmcl commented Oct 13, 2014

Is this completed?

@willmcl
Copy link
Contributor Author

willmcl commented Oct 17, 2014

This is not completed. The pixrem task was not added to the "grunt watch" task so while it seemed to be working when you run grunt, if you used the "grunt watch" task then it cleared the pixel fallbacks out again.

We need to be more careful in methodically performing and then checking the tasks before committing them. Especially as we now have so many project based on this and the updating is a bit difficult.

The commenting in the grunt file needs to be updated to include a description of the pixrem task. There are 3 steps described in lines 120 to 124. A fourth step needs to be added there and then where we declare the pixrem task so the file reads as one story.

@willmcl willmcl added the bug label Oct 31, 2014
@willmcl willmcl modified the milestones: v0.9.2, v0.10.1 Oct 31, 2014
@willmcl willmcl closed this as completed Jan 22, 2015
willmcl added a commit that referenced this issue Jan 22, 2015
Add grunt-newer plugin to address speed issues with the grunt-watch task. The watch task now only compiles the file that has been changed since the task was last run. Simple!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants