Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject empty multiaddrs #104

Closed
Stebalien opened this issue May 20, 2019 · 1 comment · Fixed by #105
Closed

Reject empty multiaddrs #104

Stebalien opened this issue May 20, 2019 · 1 comment · Fixed by #105

Comments

@Stebalien
Copy link
Member

These are almost always useless and can cause bugs like ipfs/kubo#6354.

However, this would break the marshaling code as that expects to be able to construct these. It also removes the base-case for a recursive multiaddr definition...

cc @hsanjuan, @lgierth thoughts?
Stebalien added a commit to ipfs/kubo that referenced this issue May 20, 2019
@Stebalien
commands/swarm(fix): handle empty multiaddrs
83d7405 
These are technically valid at the moment so they aren't caught when calling
`NewMultiaddr`. See multiformats/go-multiaddr#104.

fixes #6354
@Stebalien Stebalien mentioned this issue May 20, 2019
Merged
@hsanjuan
Copy link
Contributor

Nothing against it. Un-marshaling is impossible to do properly because Multiaddr is an interface and not a struct anyway. (#100 ). It might break my Multiaddr wrappers to handle that but fix would be easy.

Stebalien added a commit that referenced this issue May 20, 2019
@Stebalien
forbid empty multiaddrs
e395136 
fixes #104
@Stebalien Stebalien mentioned this issue May 20, 2019
Merged
@Menduist Menduist mentioned this issue Mar 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

forbid empty multiaddrs multiformats/go-multiaddr
2 participants
@Stebalien @hsanjuan