Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][TextField] TextField multiline resize is unstable. #42177

Open
doublebuzzwoo opened this issue May 9, 2024 · 2 comments
Open
Assignees
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! component: TextareaAutosize The React component. package: material-ui Specific to @mui/material

Comments

@doublebuzzwoo
Copy link

doublebuzzwoo commented May 9, 2024

Steps to reproduce

Link to live example: (required)

https://codesandbox.io/p/sandbox/sad-almeida-dj5t7y

Current behavior

Screen.Recording.2567-05-09.at.17.43.46.mov

Expected behavior

Screen.Recording.2567-05-09.at.17.44.47.mov

Context

I saw that the issues is already report in @mui/base refer to @mui/base/issues#168 and fixed in this PR @mui/base/pr#189 @mui/material-ui/pr#41638 . But seems it's fixed only on the TextareaAutosize component only. The TextField component of @mui/material is still bugging.

Your environment

npx @mui/envinfo
  Browsers: Chrome
  npmPackages:
    "@mui/base": "5.0.0-beta.44",
    "@mui/material": "5.15.17",

Search keywords: resize is unstable

@doublebuzzwoo doublebuzzwoo added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 9, 2024
@doublebuzzwoo doublebuzzwoo changed the title [TextField] TextField multiline resize is unstable. [material-ui][TextField] TextField multiline resize is unstable. May 9, 2024
@zannager zannager added component: text field This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels May 9, 2024
@mj12albert
Copy link
Member

Hi @doublebuzzwoo I can reproduce this in your sandbox, though when you use <TextField multiline /> it renders the same TextareaAutosize that was in the previous fix

I tried to see if this would repro in Stackblitz and accidently used a template that was still on 5.15.10, weirdly the bug does not occur then: https://stackblitz.com/edit/mcve-react-material-ui-pp76zi?file=src%2FApp.tsx 🤔

But it does on 5.15.17: https://stackblitz.com/edit/mcve-react-material-ui-nh99ds?file=src%2FApp.tsx

@ZeeshanTamboli Would you be interested in having a look at this again 🙏

@mj12albert mj12albert added bug 🐛 Something doesn't work component: TextareaAutosize The React component. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels May 13, 2024
@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented May 13, 2024

@mj12albert I think it might be related to how we released it because it's working fine for me locally.

The latest fix in @mui/base was included in v6.0.0-alpha.5, but not in v5.15.16. Therefore, the TextField with the multiline prop wasn't fixed because it didn't use the updated Base UI TextareaAutosize build code.

Could you discuss this with the team and see how we can address it? Although it was decided to only release stable packages in version 5, for this specific issue, we need to release Base UI with the latest v5 changes.

Reproduction to show that it works with v6 alpha release: https://stackblitz.com/edit/vitejs-vite-8ns17h?file=src%2FApp.tsx,src%2Fmain.tsx,package.json&terminal=dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! component: TextareaAutosize The React component. package: material-ui Specific to @mui/material
Projects
None yet
Development

No branches or pull requests

4 participants