Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-router's NavLink ref issue to MUI "Caveat with refs" Guide #17077

Closed
1 task done
robertvasile opened this issue Aug 20, 2019 · 1 comment
Closed
1 task done
Labels
support: question Community support but can be turned into an improvement

Comments

@robertvasile
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 馃挕

Quoting @oliviertassinari in #15903,

[There] is an issue with the NavLink component. This react-router component should forward its ref, it doesn't yet: remix-run/react-router#6056 (comment). I hope https://material-ui.com/guides/composition/#react-router-demo helps to explain why in more details.

Examples 馃寛

const ForwardNavLink = React.forwardRef((props, ref) => ( <NavLink {...props} innerRef={ref} /> ));

Motivation 馃敠

this should be added to https://material-ui.com/guides/composition/#caveat-with-refs

@robertvasile robertvasile changed the title Add react-router's NavLink ref issue to MUI Caveat with refs Guide Add react-router's NavLink ref issue to MUI "Caveat with refs" Guide Aug 20, 2019
@oliviertassinari
Copy link
Member

We already document it: https://material-ui.com/getting-started/faq/#how-do-i-use-react-router.

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 20, 2022
@zannager zannager added the support: question Community support but can be turned into an improvement label Dec 20, 2022
@zannager zannager removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support: question Community support but can be turned into an improvement
Projects
None yet
Development

No branches or pull requests

3 participants