Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dark mode #39

Closed
pspeter3 opened this issue Sep 3, 2020 · 3 comments · Fixed by #67
Closed

Support dark mode #39

pspeter3 opened this issue Sep 3, 2020 · 3 comments · Fixed by #67
Projects
TailwindCSS 2

Comments

@pspeter3
Copy link
Contributor

pspeter3 commented Sep 3, 2020

Tailwind is adding dark mode for v2 and is currently experimental.
@pspeter3
Copy link
Contributor Author

pspeter3 commented Sep 3, 2020

I think this can be handled by adding the right experimental flags to the configuration before running generate.

@muhammadsammy
Copy link
Owner

The CLI should generate the dark: prefix for classes if it's added to the screens property in the tailwing config.
Or does it require other configurations?

@pspeter3
Copy link
Contributor Author

pspeter3 commented Sep 4, 2020

I think that's probably right. We can close this out when dark mode is officially launched. Probably Tailwind v2 or v1.8?

@muhammadsammy muhammadsammy added this to In progress in TailwindCSS 2 Jan 2, 2021
@muhammadsammy muhammadsammy linked a pull request Jan 2, 2021 that will close this issue
feat: support dark mode classes #67
Merged
4 tasks
TailwindCSS 2 automation moved this from 🚧 In progress to ✅ Done Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
TailwindCSS 2
  
✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support dark mode classes muhammadsammy/tailwindcss-classnames
2 participants
@pspeter3 @muhammadsammy