Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate slug keycap_ in data-by-group.json #13

Closed
stevebauman opened this issue Aug 21, 2022 · 1 comment
Closed

Duplicate slug keycap_ in data-by-group.json #13

stevebauman opened this issue Aug 21, 2022 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@stevebauman
Copy link

Hey, thanks for this super useful list! I really appreciate the work you put into this ❤️

There appears to be one duplicate slug (keycap_) in the data-by-group.json. I'm not sure if this is intended or not (feel free to close if so):

"emoji": "#️⃣",
"skin_tone_support": false,
"name": "keycap #",
"slug": "keycap_",
"unicode_version": "0.6",
"emoji_version": "0.6"
},
{
"emoji": "*️⃣",
"skin_tone_support": false,
"name": "keycap *",
"slug": "keycap_",
"unicode_version": "2.0",
"emoji_version": "2.0"

@muan
Copy link
Owner

muan commented Aug 22, 2022

Thanks for reporting. Something needs to be fixed here:

// 'flag: St. Kitts & Nevis' -> 'flag_st_kitts_nevis'
// 'family: woman, woman, boy, boy' -> 'family_woman_woman_boy_boy'
// 'A button (blood type)' -> 'a_button'
// 'Cocos (Keeling) Islands' -> 'cocos_islands'
//
// Returns machine readable emoji short code
function slugify(str) {
return str.normalize("NFD").replace(/[\u0300-\u036f]/g, "").replace(/\(.+\)/g, '').trim().replace(/[\W|_]+/g, '_').toLowerCase()
}

@muan muan added bug Something isn't working help wanted Extra attention is needed labels Aug 22, 2022
@muan muan closed this as completed in ed1717a Oct 16, 2022
muan added a commit that referenced this issue Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants