Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependency failure is deprecated #40

Open
dertin opened this issue May 25, 2022 · 2 comments
Open

dependency failure is deprecated #40

dertin opened this issue May 25, 2022 · 2 comments

Comments

@dertin
Copy link

dertin commented May 25, 2022

If you liked failure's API, consider using:

Anyhow is a good replacement for failure::Error.
thiserror is a good, near drop-in replacement for #[derive(Fail)].

https://github.com/rust-lang-deprecated/failure
@Allen-Webb
Copy link
Contributor

The failure crate is affected by a CVE that was never fixed:
rust-lang-deprecated/failure#336
https://nvd.nist.gov/vuln/detail/CVE-2023-30571
GHSA-jq66-xh47-j9f3

Allen-Webb added a commit to Allen-Webb/protoc-grpcio that referenced this issue Jun 22, 2023
@Allen-Webb
Switch from 'failure' to 'anyhow'
3e8adaa 
This switchies from the 'failure' crate to the 'anyhow' crate to resolve
issue mtp401#40.

It also fixes deprecated useage of protobuf::parse_from_bytes to
Message::parse_from_bytes.
@Allen-Webb Allen-Webb mentioned this issue Jun 22, 2023
Merged
@Allen-Webb
Copy link
Contributor

This is a duplicate of #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dertin @Allen-Webb