Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump behavior different between dunamai and poetry-dynamic-versioning #45

Closed
mcous opened this issue Apr 3, 2022 · 2 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@mcous
Copy link

mcous commented Apr 3, 2022

Hi! I'm interested in integrating dunamai into the CI pipeline of some projects to do continuous deployment of prereleases and releases. Since my project adheres to semver, I want to use --bump to create prerelease versions rather than postrelease versions, which semver doesn't understand (this seems to be the reason --bump was introduced)

However, when I was playing around with --bump, I encountered something unexpected: running dunamai from git --style semver --bump on a tagged commit bumps to the next patch version rather than returning the tag version unchanged. Is this an intentional behavior?

When I went to look at poetry-dynamic-versioning, I noticed this in the documentation (emphasis mine):

bump: Boolean. Default: false. If true, then increment the last part of the version base by 1, unless the stage is set, in which case increment the revision by 1 or set it to a default of 2 if there was no revision. Does nothing when on a commit with a version tag.

Should this be the behavior of the dunamai library itself? I would prefer it, because it would allow me to put dunamai ... --bump in my CI scripts to produce both release and pre-release version strings.

@mtkennerly mtkennerly added the bug Something isn't working label Apr 5, 2022
@mtkennerly
Copy link
Owner

Thanks for pointing this out. I would say this is an oversight in Dunamai.

mtkennerly added a commit that referenced this issue Apr 5, 2022
@mtkennerly mtkennerly added this to the v1.11.1 milestone Apr 5, 2022
@mtkennerly
Copy link
Owner

This is now fixed in v1.11.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants