Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename test to comply with module.CheckFilePath #60

Merged
merged 1 commit into from Nov 24, 2020
Merged

rename test to comply with module.CheckFilePath #60

merged 1 commit into from Nov 24, 2020

Conversation

sgmitchell
Copy link
Contributor

Description
Rename test and corresponding testdata file to appease go modules

Go modules will zip up everything in the repo, which results in files under testdata being run through CheckFilePath() which does not like ' in file names.

Removing that character from the testdata file (and corresponding tests) makes it happy. (change and working url)

An alternative solution proposed in multiple places is to just add an empty go.mod file to the testdata folder (change and working url)

Related issue(s)
Fixes #59

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #60 (4aeed2b) into master (085f270) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   50.13%   50.13%           
=======================================
  Files          12       12           
  Lines         375      375           
=======================================
  Hits          188      188           
  Misses        183      183           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085f270...4aeed2b. Read the comment docs.

@mszostok
Copy link
Owner

Hi @sgmitchell, thanks for fixing that problem! I wasn't aware of it.

Removing the ' makes sense as this is quite uncommon for filenames, so probably I shouldn't use it.

Regarding the option with the empty go.mod, I'm not sure AFIU this will result in downloading source code (tests also) without the testdata folder, which I know that in most use cases it's not used but still seems odd to me.

Provided solution LGTM 🚀

@mszostok mszostok merged commit e5e11b0 into mszostok:master Nov 24, 2020
@sgmitchell sgmitchell deleted the change-test-name branch November 24, 2020 19:08
@mszostok mszostok added this to the v0.6.0 milestone Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

410 Gone from reading https://sum.golang.org/lookup/github.com/mszostok/codeowners-validator@v0.5.1
2 participants