Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurability for the list of ignored owners #55

Merged
merged 2 commits into from Oct 31, 2020

Conversation

majakurcius
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Add configurability for the list of ignored owners
  • Update README, and fix its structure
  • Fix typos

Related issue(s)

Fixes #54

@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #55 into master will increase coverage by 4.31%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   45.82%   50.13%   +4.31%     
==========================================
  Files          13       12       -1     
  Lines         371      375       +4     
==========================================
+ Hits          170      188      +18     
+ Misses        199      183      -16     
- Partials        2        4       +2     
Impacted Files Coverage Δ
internal/check/valid_owner.go 29.82% <82.35%> (+19.04%) ⬆️
internal/check/valid_owner_error.go 50.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97fb795...c3e71ce. Read the comment docs.

@mszostok
Copy link
Owner

mszostok commented Oct 31, 2020

As discussed f2f, the integration tests are not working on forked PRs (yet 🙏 ). This will be documented in a separate PR :)

merging 🚀

@mszostok mszostok merged commit 4f46df1 into mszostok:master Oct 31, 2020
@majakurcius majakurcius deleted the issue-54-ignored-owner branch October 31, 2020 16:20
@mszostok mszostok added documentation enhancement New feature or request labels Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Valid Owner Checker] Make the ignored owners configurable
2 participants