Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for outside collaborators #115

Open
mszostok opened this issue Feb 11, 2022 · 1 comment · May be fixed by #222
Open

Add support for outside collaborators #115

mszostok opened this issue Feb 11, 2022 · 1 comment · May be fixed by #222
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mszostok
Copy link
Owner

Description

There is an option to add people as outside collaborators.

The codeowners-validator should include those members when in owners check as currently they are ignored.

Reasons

Currently, owners check my produce false negatives when CODEOWNRES files has outside collaborators as owners.

@mszostok mszostok added the bug Something isn't working label Feb 11, 2022
@mszostok mszostok added this to the v1.0.0 milestone Feb 11, 2022
@mszostok mszostok self-assigned this Feb 11, 2022
@bobertrublik
Copy link

bobertrublik commented Apr 24, 2023

I would help out with a PR for this issue. I looked into the code and I can do one of the following:

  1. Add an outsideCollaborators map variable to ValidOwners struct and a function which adds all outside collaborators part of the repository to the map. Inside function Check in valid_owner.go we can then continue the for loop on any outside collaborators with access to the repository. The second option is validating outside collaborators in validateGitHubUser().
  2. Create a second initOrgListMembers() function which adds outside collaborators to the orgMembers map. This joins organization members with outside collaborators and the check succeeds in validateGitHubUser().

I would probably prefer option 1 since we can differentiate between different types of users. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants