feat: do not interfere with shared workers #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7d7f7d1:
|
kettanaito
previously approved these changes
Nov 3, 2022
There was a problem hiding this comment.
This looks fantastic! Thank you for adding this support, @mucsi96 🎉
Let me try this out and get back to you.
kettanaito
reviewed
Nov 3, 2022
test/msw-api/setup-worker/scenarios/shared-worker/shared-worker.test.ts
Outdated
Show resolved
Hide resolved
kettanaito
changed the title
kettanaito
changed the title
kettanaito
approved these changes
Nov 3, 2022
|
I'd like to group this with #1445 since both changes are potentially breaking and would fall nicely into a single minor release. |
Released: v0.48.0 🎉This has been released in v0.48.0! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I am adding support for shared workers.
The issue is that in case of shared workers the request event doesn't contain
clientId.Due to that the
clientisundefinedwhich breaks the code here