chore: fixes tests on Windows using Unix-style path #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bdc9f7a:
|
Changes the commitlint configuration to allow commit bodies of any length.
Fixes a test passing a Unix-style path to child_process.exec which failed on Windows by wrapping it in `path.resolve`. Fixes a test relying on some internal logic which only took Unix-style paths into account.
kettanaito
approved these changes
Oct 1, 2022
There was a problem hiding this comment.
Thanks for making the tests better! Welcome to contributors, @kleinfreund! 🎉
Released: v0.47.4 🎉This has been released in v0.47.4! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that tests weren't passing on Windows and went ahead and fixed them. All unit and integration tests are now passing on Windows, too.
Note: This also contains a controversial change to the commitlint.config.js which removes the line length limitations from commit bodies. I've made that change because I wasn't able to commit. Of course this isn't my repository so I'm happily removing this change if it's unwanted. However, I'd like to take this opportunity to argue against such rules: Nowadays, there just isn't a good reason for hard-wrapping code or natural language content (which I believe is the main reason these rules exist). Editors have capabilities to soft-wrap as a user likes per file type/language. Additionally, I've come to really like writing up a commit's changes in ... the commit itself. This saves from needing to do so in two places: the commit and the inadvertent pull/merge request.
In any case, this is not for me to decide, so please let me know whether I should be reverting this.
Changes
Fixes a test passing a Unix-style path to child_process.exec which failed on Windows by wrapping it in
path.resolve.Fixes a test relying on some internal logic which only took Unix-style paths into account.
Changes the commitlint configuration to allow commit bodies of any length.