Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print response log only when response arrives #1392

Merged
merged 1 commit into from Sep 7, 2022

Conversation

kettanaito
Copy link
Member

@kettanaito kettanaito commented Sep 7, 2022

Changes

  • The response log message in the console will now be printed only once the response actually arrives. This will respect the response timing in visual reporting.
  • Fallback mode will now emit response:mocked and response:bypass life-cycle events (previously, never emitted those, that's a bug).
  • Removes onMockedResponseSent internal hook in handleRequest.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 71a699d:

Sandbox Source
MSW React Configuration

@kettanaito kettanaito merged commit 638fad9 into main Sep 7, 2022
@kettanaito kettanaito deleted the fix/response-log branch September 7, 2022 10:52
@kettanaito
Copy link
Member Author

Released: v0.47.1 🎉

This has been released in v0.47.1!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display request log once the response is signaled by the worker
1 participant