Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add explicit exports map in package.json #1383

Merged
merged 5 commits into from Sep 3, 2022

Conversation

ivanhofer
Copy link
Contributor

This PR adds the missing exports field to the package.json.
This makes msw compatible with TypeScript projects using the moduleResolution set to node16.

https://www.typescriptlang.org/docs/handbook/esm-node.html

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cd66050:

Sandbox Source
MSW React Configuration

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. Waiting for the tests to pass.

@kettanaito
Copy link
Member

Thank you, @ivanhofer @mattcosta7 for your contribution! You folks are simply fantastic. Let's ship this.

@kettanaito kettanaito changed the title feat: adds package.json exports field feat: add explicit exports map in package.json Sep 3, 2022
@kettanaito kettanaito merged commit 5e1c1a6 into mswjs:main Sep 3, 2022
@kettanaito
Copy link
Member

Released: v0.47.0 🎉

This has been released in v0.47.0!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants