Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruby2_keywords to delegating methods #62

Merged
merged 2 commits into from Jan 11, 2021
Merged

Add ruby2_keywords to delegating methods #62

merged 2 commits into from Jan 11, 2021

Conversation

jochenseeber
Copy link
Contributor

Pull request for #56. Maybe @eregon could have a look at this?

One thing I am not sure about is if calling module_function for a method after calling ruby2_keywords works correctly.

Copy link
Contributor

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@codecov-io
Copy link

codecov-io commented Jan 10, 2021

Codecov Report

Merging #62 (45d2544) into master (5f0e1df) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #62   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           83        89    +6     
=========================================
+ Hits            83        89    +6     
Impacted Files Coverage Δ
lib/docile.rb 100.00% <100.00%> (ø)
lib/docile/chaining_fallback_context_proxy.rb 100.00% <100.00%> (ø)
lib/docile/execution.rb 100.00% <100.00%> (ø)
lib/docile/fallback_context_proxy.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f0e1df...45d2544. Read the comment docs.

@ms-ati ms-ati merged commit 5001479 into ms-ati:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants