Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for 1.8.7 and perhaps all EOL Rubies #58

Closed
3 of 7 tasks
ms-ati opened this issue Jan 4, 2021 · 1 comment · Fixed by #65
Closed
3 of 7 tasks

Remove support for 1.8.7 and perhaps all EOL Rubies #58

ms-ati opened this issue Jan 4, 2021 · 1 comment · Fixed by #65

Comments

@ms-ati
Copy link
Owner

ms-ati commented Jan 4, 2021

It now appears that, in addition to being end-of-life for years, Ruby 1.8.7 is no longer runnable on Travis CI.

For comparison, Github Actions supports no Rubies older than 2.1.

Therefore, it's now time to remove testing, and then support, for Ruby 1.8. In Docile, this will result in actual code changes, as code paths and choices do exist solely to support 1.8 today.

How to use this ticket

I'd like to use this ticket to capture (a) plans and notes on what code can change to remove this support, and (b) links to every PR that pertains to removing this support. The final PRs should be for a new minor version.

What about Ruby 1.9, etc?

Do you use Docile on an end-of-life ("EOL") Ruby version, such as 1.9.3? If so, please respond to this ticket to let me know. If nobody is actively following this project and using EOL Rubies, I'd like to consider removing support for all of them. However, I would prefer to continue to support any Rubies that are actually in use by folks following this project, so please respond if you would be impacted!

Checklist

  • Remove 1.8.7 and REE from Travis CI (see Update .travis.yml to remove 1.8.7 and REE #61)
  • singleton_class - stop using the 1.8.7 fallback pattern
  • FallbackContextProxy#instance_variables - stop supporting Strings on 1.8
  • docile.gemspec and on_what.rb - remove all pinned dependencies for 1.8
  • README and any other documentation
  • HISTORY.md
  • ??? Please suggest more items below!
@ms-ati ms-ati mentioned this issue Jan 4, 2021
ms-ati added a commit that referenced this issue Jan 4, 2021
ms-ati added a commit that referenced this issue Jan 5, 2021
@ms-ati ms-ati changed the title Remove support for 1.8.7 Remove support for 1.8.7 and perhaps all EOL Rubies Jan 13, 2021
ms-ati added a commit that referenced this issue Jan 13, 2021
Announce timeframe of Feb 1st 2021 to decide whether to continue
to support any EOL Ruby versions (< 2.5 as of today Jan 13 2021), and
if so which ones.

Direct comments to issue #58.
ms-ati added a commit that referenced this issue Jan 13, 2021
Official source for EOL vs support status for Ruby versions, for 
the issue #58 to decide which EOL versions, if any, to continue
to support.
@ms-ati
Copy link
Owner Author

ms-ati commented Feb 7, 2021

UPDATE: As of Sun Feb 7 2021, there have been no comments on this issue requesting continued support for any EOL Rubies.

Context: as of today, all Ruby versions prior to 2.5 are end-of-life (EOL)

We should start to move forward with plans to remove support for some or all of them.

ms-ati added a commit that referenced this issue May 4, 2021
In this PR:
  * Temporarily remove all YARD doc config, to be added back
    after migrating CI to Github Actions, to simplify config
    and dependencies
  * Remove all testing and references to < 2.6 Rubies
  * Simplify JRuby and TruffleRuby testing to latest stable versions

NOT in this PR:
  * Any simplifying code changes that are now possible due to
    removing support for EOL Rubies

Closes #58
@ms-ati ms-ati closed this as completed in #65 May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant