Is ruby2_keywords also required here?

[jochenseeber]

#52 fixed keyword argument delegation (learned something new, thanks!)

Do we also need this here (cc @eregon)?

docile/lib/docile/fallback_context_proxy.rb

Line 55 in 4300547

send(:define_method, :method_missing) do |method, *args, &block|

[eregon]

Yes, it's also needed, if the method called by receiver.__send__(method.to_sym, *args, &block) has keyword arguments.

It's a good idea to review all usages of rest arguments (e.g., *args) that are used for delegation, and might potentially call a method which has keyword arguments. In that case, ruby2_keywords should be used to correctly pass keyword arguments as-is, and not transforming them back to a positional Hash argument.

[ms-ati]

cc @jochenseeber @eregon and others, if you'd consider proposing a PR to address this It would be greatly appreciated and welcome! :)

[jochenseeber]

I can try and create a PR, but it will be 2 weeks before I have time.

[ms-ati]

@jochenseeber is this closed by #62 ?

[ms-ati]

@jochenseeber @eregon I'm going to mark this closed by #62 -- please do feel free to re-open this issue if I've misunderstood and it's not fixed.

Also, I've just released v1.3.5 to Rubygems with these changes!