Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for when DSL object is also the block's context #30

Merged
merged 3 commits into from May 24, 2018
Merged

Fix for when DSL object is also the block's context #30

merged 3 commits into from May 24, 2018

Conversation

taichi-ishitani
Copy link
Contributor

Hi,
I have fixed issue #29.
Could you please review my fix?

@codecov-io
Copy link

codecov-io commented May 23, 2018

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #30   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          66     67    +1     
=====================================
+ Hits           66     67    +1
Impacted Files Coverage Δ
lib/docile/execution.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb966f...57928f6. Read the comment docs.

@ms-ati
Copy link
Owner

ms-ati commented May 24, 2018

Thank you!

@ms-ati ms-ati merged commit fcbd684 into ms-ati:master May 24, 2018
@taichi-ishitani taichi-ishitani deleted the fix_issue_29 branch May 24, 2018 08:33
@ms-ati ms-ati changed the title fix #29 Fix for when DSL object is also the block's context May 24, 2018
@ms-ati
Copy link
Owner

ms-ati commented May 24, 2018

@taichi-ishitani this was released in v1.3.1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants