Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supporting webpack 5 #234

Merged
merged 3 commits into from Sep 19, 2020
Merged

feat: supporting webpack 5 #234

merged 3 commits into from Sep 19, 2020

Conversation

mrsteele
Copy link
Owner

@mrsteele mrsteele commented Sep 1, 2020

Closes #184 as well as some other artifact issues I was seeing.

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #234 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   98.67%   98.72%   +0.05%     
==========================================
  Files           2        2              
  Lines         151      157       +6     
  Branches       38       38              
==========================================
+ Hits          149      155       +6     
  Misses          2        2              
Impacted Files Coverage Δ
src/index.js 98.41% <100.00%> (+0.07%) ⬆️
index.js 98.93% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea28c6c...b859f6b. Read the comment docs.

@marcelgerber marcelgerber mentioned this pull request Sep 9, 2020
20 tasks
@marcelgerber
Copy link

Hey, just a quick question, when is this expected to land?
Is there anything holding this off?

I would like to build on it, and since we're using dotenv-webpack in our project that's a blocker for me right now.

@mrsteele
Copy link
Owner Author

@marcelgerber Haha I'm kinda waiting for someone like you to tell me they need it. Normally a little hesitant to update so I'll update all those dependencies then try and get this in.

@marcelgerber
Copy link

@mrsteele Great, and thank you so much for the effort you're putting in here. Greatly appreciated!

mrsteele and others added 2 commits September 18, 2020 15:07
BREAKING CHANGE: adding additional env replacements for unreferenced variables for webpack v5
@mrsteele mrsteele merged commit 7749894 into master Sep 19, 2020
@mrsteele mrsteele deleted the feature/supportingWebpack5 branch September 19, 2020 06:59
@mrsteele
Copy link
Owner Author

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

tobias-trozowski pushed a commit to tobias-trozowski/dotenv-webpack that referenced this pull request Nov 12, 2020
* feat: supporting webpack 5

* feat: dropping support for node v9
BREAKING CHANGE: adding additional env replacements for unreferenced variables for webpack v5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does this work with Webpack 5?
2 participants