Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Privacy Manifest #659

Open
tristanheilman opened this issue Apr 11, 2024 · 6 comments
Open

Apple Privacy Manifest #659

tristanheilman opened this issue Apr 11, 2024 · 6 comments

Comments

@tristanheilman
Copy link

tristanheilman commented Apr 11, 2024

Starting May 1st, Apple is requiring declarations for API usage as part of their privacy update for App Store submissions. I believe this package will need to include the NSPrivacyAccessedAPICategoryUserDefaults API declaration.

I ran a scan on my project and found this

Found potentially required reason API usage 'UserDefaults' in './WridzRefactorV2/ios/Pods/Headers/Public/MMKV/MMKV.h'
Line numbers: 369 371 
Found potentially required reason API usage 'NSUserDefaults' in './WridzRefactorV2/ios/Pods/Headers/Public/MMKV/MMKV.h'
Found potentially required reason API usage 'UserDefaults' in './WridzRefactorV2/ios/Pods/MMKV/iOS/MMKV/MMKV/MMKV.h'
Line numbers: 369 371 
Found potentially required reason API usage 'NSUserDefaults' in './WridzRefactorV2/ios/Pods/MMKV/iOS/MMKV/MMKV/MMKV.h'
Found potentially required reason API usage 'UserDefaults' in './WridzRefactorV2/ios/Pods/MMKV/iOS/MMKV/MMKV/MMKV.h'
Line numbers: 369 371 
Found potentially required reason API usage 'NSUserDefaults' in './WridzRefactorV2/ios/Pods/MMKV/iOS/MMKV/MMKV/MMKV.h'

Here is a link to a discussion on the react-native-community repo
react-native-community/discussions-and-proposals#766

Link to Apple Documentation outlining this privacy update
https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api

@mrousavy
Copy link
Owner

MMKV Core is already working on this; Tencent/MMKV@06797a7

We don't need a privacy manifest, we will just no longer rely on those sensitive APIs.

@mshivam019
Copy link

will there be a new release soon, for this patch?

@mrousavy
Copy link
Owner

MMKV didn't create a new release yet.

@tristanheilman
Copy link
Author

tristanheilman commented Apr 29, 2024

Looks like the new release was shared 5 days ago. https://github.com/Tencent/MMKV/releases/tag/v1.3.5
Running pod install picked up the new SDK versions so looks like this can be closed.

@matteodanelli
Copy link

@tristanheilman where do you run pod install? How can the MMKV module inside can update?

@tristanheilman
Copy link
Author

@tristanheilman where do you run pod install? How can the MMKV module inside can update?

I have react-native-mmkv ^2.12.2 installed. Just cd into your iOS directory and run pod install --repo-update. The update to the MMKV SDK was a patch update, reinstalling pods should pull in the updated version. After running pod install, check the Podfile.lock folder for MMKV ~> 1.3.5

If you have 1.3.5 installed then you are good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants