Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support #12

Open
mrousavy opened this issue Mar 2, 2021 · 1 comment · May be fixed by #13
Open

Windows support #12

mrousavy opened this issue Mar 2, 2021 · 1 comment · May be fixed by #13
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mrousavy
Copy link
Owner

mrousavy commented Mar 2, 2021

Would be nice to have support for react-native-windows.

I've already started working on this at the support-windows branch, but hit a roadblock because I couldn't add the MMKV/Core/core.vcxproj to my solution since that's VS 2015 and apparently my VS 2019 can't read that:

No idea how to add that without touching the submodule, but if anyone has some ideas let me know!
@mrousavy mrousavy added enhancement New feature or request help wanted Extra attention is needed labels Mar 2, 2021
@mrousavy mrousavy linked a pull request Mar 2, 2021 that will close this issue
Draft
@sauldom102 sauldom102 mentioned this issue Jul 8, 2021
Closed
@mrousavy mrousavy mentioned this issue Jan 6, 2022
Closed
@creambyemute
Copy link

creambyemute commented Feb 28, 2022 •
edited

@mrousavy I guess you created the solution/vcxproj with VS2016/VS2015? So probably it is only a matter of reinitializing the windows project with VS2019 or VS2022?

Edit: Sorry I read the PR again and it's the MMKV module that's VS2015. Hmm I'll lookup if it's somehow possible.

@rish033 rish033 mentioned this issue Mar 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Windows support mrousavy/react-native-mmkv
2 participants
@creambyemute @mrousavy