Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(json2csv): use sort function for sortHeader option #217

Merged
merged 1 commit into from Jan 15, 2022
Merged

feat(json2csv): use sort function for sortHeader option #217

merged 1 commit into from Jan 15, 2022

Conversation

mebibou
Copy link
Contributor

@mebibou mebibou commented Jan 14, 2022

Background Information

I have...

  • added at least one test to verify the failure condition is fixed.
  • verified the tests are passing.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.039% when pulling 1706f0d on mebibou:feat/sort-header-function into 023eec1 on mrodrig:stable.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.039% when pulling 1706f0d on mebibou:feat/sort-header-function into 023eec1 on mrodrig:stable.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.039% when pulling 1706f0d on mebibou:feat/sort-header-function into 023eec1 on mrodrig:stable.

@mrodrig
Copy link
Owner

mrodrig commented Jan 15, 2022

Looks great, thanks for the PR @mebibou! I'll get this merged in and released out shortly on NPM as 3.16.0

@mrodrig mrodrig merged commit 5a8b7e0 into mrodrig:stable Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mebibou @coveralls @mrodrig