ISSUE-351: Bash style brace expansions stops working after upgrade to 3.2.8 #353
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmlnc
force-pushed
the
ISSUE-351_fix_brace_expansion_checker
branch
from
cac7455 to
028cfe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This is a final fix for #351 based on the first regular expression (click).
What changes did you make? (Give an overview)
So, аfter correcting the polynomial explosion (1, 2), we had problems with detecting brace expansion.
I couldn't write a valid regular expression (taking into account the current versions of platform) that would work with the pattern from issue (
abc/{a.txt,b.txt}), so I rewrote it to a regular function. This function has a more generalized view and should work with any patterns.It seems to me that the current solution is easier to understand and support.