fastGlob('\\!dir/*') finds nothing even though a directory named !dir exists

[thorn0]

Environment

• OS Version: WSL (10.0.18363.657) Ubuntu 18.04.1 LTS
• Node.js Version: v10.15.0

Actual behavior

Nothing found.

Expected behavior

Files found.

Steps to reproduce

1. Create a non-empty dir named !dir
2. Run the code sample below

Code sample

console.log(require("fast-glob").sync("\\!dir/*"))

[thorn0]

Workaround: require("fast-glob").sync("@(!)dir/*")

[mrmlnc]

Looks like the problem around the glob-parent package. The first part of the pattern is defined as the base directory.

{ pattern: '\\!dir/*', base: '\\!dir' }

[anthonytranDev]

@thorn0

Hey are you still working on this ticket. Was wondering whether I can help out?

Wanted to ask first - don't want to step over your toes

[thorn0]

I'm not working on it. It was just a bug report.

[mrmlnc]

I created a pull request to fix this problem in the glob-parent package (gulpjs/glob-parent#26).

@thorn0 & @anthonytranDev, please tell me in which case you are use ! in the directory name?

[mrmlnc]

Fixed by glob-parent@5.1.1.

In the simplest case, run this command to get the latest versions of dependencies:

npm i fast-glob