Skip to content

Fix umd bundle #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2019
Merged

Fix umd bundle #85

merged 2 commits into from
Jul 13, 2019
+86 −5

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Jul 11, 2019 •
edited
Loading

Currently umd calls not defined require function. In this diff I
bundled react-is in umd to let it work in browsers.

Nothing is changed for cjs build.

Closes #77 and #58

/cc @mridgway @Andarist

@TrySound
Fix umd bundle
e0ed438 
Currently umd calls not defined `require` function. In this diff I
bundled `react-is` in umd to let it work in browsers.

Nothing is changed for cjs build.

Closes #77 and #58
Andarist
Andarist reviewed Jul 11, 2019
View reviewed changes
@TrySound
Copy link
Contributor Author

@mridgway the fix done

@mridgway mridgway merged commit edb25c3 into mridgway:master Jul 13, 2019
@TrySound TrySound deleted the fix-umd branch July 13, 2019 18:58
@Andarist Andarist mentioned this pull request Jul 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andarist Andarist

@mridgway mridgway

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TrySound @mridgway @Andarist