Use const fn #56
Merged
Use const fn #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I'm a bit rusty and requested @akhilles for a deeper look any thoughts on release plan? |
This changes require stable rust, so migration is not that painful. |
|
Supportive of that. What do you think about adding/updating some tests to prevent accidental regression? |
akhilles
approved these changes
Oct 4, 2020
There was a problem hiding this comment.
Changes look good. Btw, a couple of const fns in src/table.rs and src/util.rs can be simplified quite a bit in Rust 1.46. In terms of release plan, I think it's reasonable to bump MSRV to 1.46 for v2. Might be worth adding fuzz testing before the actual 2.0.0 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.46 significantly extends
const fnsupport, so now it's possible to perform all calculations at compile time (and hence invoke crc in const context). This PR makes all funcs const (with the only exceptionDigest.update, which mutates state and not yet available in stable).