Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize on feature flags vs rustc --cfg flags for default impl selection #113

Open
akhilles opened this issue Mar 1, 2024 · 0 comments
Open

Finalize on feature flags vs rustc --cfg flags for default impl selection #113

akhilles opened this issue Mar 1, 2024 · 0 comments

Comments

@akhilles
Copy link
Collaborator

akhilles commented Mar 1, 2024 •
edited

Context: #92 (comment)

Some advantages of --cfg flags:

  • Don't have to be strictly additive
  • Can only be set when compiling a binary (hidden to libraries)
  • Can throw a compile error if incompatible flags are set
  • Can stop supporting them without breaking semver
@akhilles akhilles mentioned this issue Mar 1, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akhilles