Skip to content

Update constants.js #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2019
Merged

Update constants.js #49

merged 2 commits into from
Feb 18, 2019

Conversation

mukeshydv
Copy link
Contributor

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
made server keep alive 2-byte integer
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change needed also for MQTT 3.1.1?

@mukeshydv
Copy link
Contributor Author

is this change needed also for MQTT 3.1.1?

This is related to properties, which is added in 5 so I don't think so.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mcollina mcollina requested a review from scarry1992 February 16, 2019 16:47
@mcollina
Copy link
Member

@scarry1992 can you please check this one?

Copy link
Contributor

@scarry1992 scarry1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants