fix various options definition for ts usage #1043
Merged
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looing at mqtt-packet, 'will' payload should be a buffer
mcollina
reviewed
Feb 10, 2020
|
I've also marked 'qos' as optional on client.publish() |
vincent-tr
changed the title
mcollina
requested changes
Feb 11, 2020
|
Sure, I did not see we have tests on typescript definitions, I will add some. |
|
👍 Thanks! |
|
Is there any chance to get it released soon? |
PremiumBurger
pushed a commit
to quickstar/MQTT.js
that referenced
this pull request
Nov 27, 2020
* fix connect options will payload type Looing at mqtt-packet, 'will' payload should be a buffer * PR feedback * qos should be optional * add buffer/string + optional qos tests * try to stick to the file's coding style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at mqtt-packet, 'will' payload should be a buffer