Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable scheduled action for forks #245

Closed
JohelEGP opened this issue Feb 27, 2021 · 6 comments
Closed

ci: disable scheduled action for forks #245

JohelEGP opened this issue Feb 27, 2021 · 6 comments
Labels
continuous integration Changes that affect CI
Milestone

Comments

@JohelEGP
Copy link
Collaborator

See https://github.com/johelegp/units-1/actions/runs/604611174.

@mpusz
Copy link
Owner

mpusz commented Feb 27, 2021

Why do you want to disable this for forks? We need as many checks as possible in CI to confirm the quality of PRs.

If you are referring to the fact that CI broke than it is a temporary problem with Conan 1.34.0. I reported this issue to Conan developers and Conan 1.34.1 with the patch conan-io/conan#8568 is coming soon.

@JohelEGP
Copy link
Collaborator Author

Do all forks really need to run this on a schedule? Isn't it enough for the main repository to do it? I suspect most fork master branches stay at the commit they were forked from, which would leave them running them until they have 60 days of inactivity. The workflow should still run on PRs and pushes.

@mpusz
Copy link
Owner

mpusz commented Mar 4, 2021

I think I do not understand what do you mean by "on a schedule". I thought that this one is only run after new commits are pushed to the repo. If nothing is pushed this Action should not fire, right?

@mpusz
Copy link
Owner

mpusz commented Mar 5, 2021

Ohh, my bad. I was not aware of this. It seems that I copy-pasted most of the action code and didn't notice that. I will remove the scheduled task ASAP.

@mpusz
Copy link
Owner

mpusz commented Mar 5, 2021

Closed with a22600c

@mpusz mpusz closed this as completed Mar 5, 2021
@mpusz mpusz added the continuous integration Changes that affect CI label May 9, 2021
@mpusz mpusz added this to To do in Issues Kanban Board via automation May 9, 2021
@mpusz mpusz added this to the v0.7.0 milestone May 9, 2021
@mpusz mpusz moved this from To do to Done in Issues Kanban Board May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Changes that affect CI
Projects
Development

Successfully merging a pull request may close this issue.

2 participants