New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Web UI session experience #4804
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all of the hacks and support infrastructure around Rack sessions. Rails provides this by default so we don't need it for 90% of users. The other 10% should know and provide a Rack session. This is a big change and has the potential to break many installs. It will be part of the 7.0 major version bump and require a lengthy beta period to ensure we document as many edge cases and solutions as possible. See also #4671, #4728 and many others.
* Remove HEAD aliases which don't work * Add simplest possible heartbeat HEAD which returns 200 or 500.
This was referenced Mar 15, 2021
This was referenced Mar 16, 2021
@mperham you may want to update https://github.com/mperham/sidekiq/wiki/Monitoring#forbidden (I presume you'd rather do it than me :) nice release |
This was referenced Mar 17, 2021
marcelolx
added a commit
to sidekiq-scheduler/sidekiq-scheduler
that referenced
this pull request
May 14, 2021
Since sidekiq/sidekiq#4804 sidekiq requires to be configured explicitly with a rack session.
Bialogs
pushed a commit
to SaraAlert/SaraAlert
that referenced
this pull request
Sep 14, 2021
Bialogs
pushed a commit
to SaraAlert/SaraAlert
that referenced
this pull request
Sep 14, 2021
tstrass
pushed a commit
to SaraAlert/SaraAlert
that referenced
this pull request
Sep 20, 2021
tstrass
pushed a commit
to SaraAlert/SaraAlert
that referenced
this pull request
Sep 27, 2021
SuperTux88
added a commit
to SuperTux88/diaspora
that referenced
this pull request
Oct 27, 2021
SuperTux88
added a commit
to diaspora/diaspora
that referenced
this pull request
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For years many people have struggled to configure a Rack session with the rewritten Web UI introduced in v4.2.0. "Forbidden" is a common complaint and there are many hacks around this area in many apps. This change is an attempt to clean up this problem and hopefully guide people back onto the happy path and away from those hacks.
The Web UI no longer exposes any session configuration. Anything like
Sidekiq::Web.sessions = false
andSidekiq::Web.session_secret = ...
is no longer available.The Web UI only supports two modes of operation now:
Rails
For Rails, as long as you mount the Web UI within the routes, it should provide a session for anything within the routes.
Rack
For Rack, a basic cookie session is straightforward to enable: