Ensure Rack::ContentLength is loaded as middleware #4541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Please add a changelog entry. |
6.0.5 removed Sidekiq::WebApplication's own Content-Length header calculation, expecting Rack to do it instead via some middleware. This was to fix an issue where New Relic would inject content into Sidekiq's Web UI after the hand crafted content length was calculated. While such middleware exists, it's not enabled by default (at least in a Rails app) and so the HTTP response doesn't have the header at all. The absence of the header has caused unexpected behaviour in an nginx and HAProxy setup, causing each page load to take exactly 20 seconds. The suspicion is that, without the Content-Length response header, HAProxy waits a preset amount of time before deciding the body must have surely been finished and then reponds.
f3ndot
force-pushed
the
ensure-rack-content-length-middleware
branch
from
7dd6273
to
b07e99d
Compare
|
@mperham all set. Thanks for your review. |
|
The next version of Sidekiq will revert this as I see Content-Length as orthogonal to the Web UI. I believe Rails will handle it automatically. If you are running the Web UI directly, you can ‘use Rack::ContentLength’ beforehand. If neither of these is applicable, let me know and we can figure out something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.0.5 removed
Sidekiq::WebApplication's own Content-Length header calculation, expecting Rack to do it instead via some middleware (675e40c). This was to fix an issue where New Relic would inject content into Sidekiq's Web UI after the hand crafted content length was calculated (#4440). While such middleware exists, it's not enabled by default (at least in a Rails app) and so the HTTP response doesn't have the header at all.The absence of the header has caused unexpected behaviour in an nginx and HAProxy setup we use in production systems, causing each page load to take exactly 20 seconds. The suspicion is that, without the Content-Length response header, HAProxy waits a preset amount of time before deciding the body must have surely by finished and then responds.