Do not connect to redis at exit if not needed #4502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fix for sidekiq#4498 introduced a call-back that is executed at ruby VM exit and tries to connect to redis. This call-back is also executed in CI runs and in all other cases where sidekiq is loaded but not used with real redis. As a work-around, keep the at_exit hook but communicate to redis only if there is something to send, i.e. the number of processed or failed jobs is greater than zero
misdoro
force-pushed
the
quickfix_do_not_connect_to_redis_on_exit
branch
from
a55c1ed
to
b2b7399
Compare
|
@mperham WDYT ? |
This was referenced Mar 24, 2020
|
The root problem for many people is that they are using the |
|
Ah, we are using that, but we're also enterprise, so I'll work on moving us over to enterprise cron. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #4498 introduced a callback that is executed at ruby VM exit and tries to connect to redis.
This callback is also executed in CI runs and in all other cases where sidekiq is loaded but not used with real redis.
As a work-around, keep the at_exit hook but communicate to redis only if there is something to send, i.e. the number of processed or failed jobs is greater than zero