Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unlink, not del, for performance #4449

Merged
merged 2 commits into from Feb 5, 2020
Merged

Use unlink, not del, for performance #4449

merged 2 commits into from Feb 5, 2020

Conversation

mperham
Copy link
Collaborator

@mperham mperham commented Feb 5, 2020

This makes deleting/clearing large queues much faster.

@mperham
Copy link
Collaborator Author

mperham commented Feb 5, 2020

This requires Redis 4.0+ which is a requirement for Sidekiq 6.0+

@mperham mperham merged commit e44d5b8 into master Feb 5, 2020
@mperham mperham deleted the use_unlink branch February 5, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant