Consider Default Required Path on Config File Search #4077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wrote the #4076 for this. I don't think this fix will work. In particular, you want to have a test like the one I've added there - where no |
|
Sorry, why do you think it will not work? Here is the spec for bare |
|
Oh, good point, actually that will work - had got confused about setting |
mperham
approved these changes
Jan 8, 2019
|
master should be fixed now, anyone want to confirm? |
Master seems to have fixed it for my deployment |
Yep, can confirm this fix as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4075
To find out the config file dir we make the next assumptions with the corresponding precedence:
:requireoption is an existing dir – take it forconfig/sidekiq.yml:requireoption is a file – take default Sidekiq:requireoption –.(current directory):requireoption is ommitted – take default Sidekiq:requireoption –.(current directory)In tests we stub default Sidekiq
:requireoption (.) with the dummy app folder (./test/dummy).