New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reliable scheduler does not handle bad JSON well #4053

Closed

mperham opened this issue Dec 11, 2018 · 0 comments

Collaborator

mperham commented Dec 11, 2018 •

edited

If a job with invalid JSON is scheduled and the reliable scheduler is in use, the following error is generated when parsing the JSON:

Redis::CommandError: ERR Error running script (call to f_1475bc7aecf38b9bd58c4be7bbcf284865213db9): @user_script:6: user_script:6: Expected value but found invalid token at character 1

Not useful at all. With this fix, the bad JSON is returned as error context:

Redis::CommandError: Bad JSON found by reliable scheduler: some bad data

The text was updated successfully, but these errors were encountered:

mperham closed this as completed

mperham added a commit that referenced this issue


          #4053

6a7bf2d

Tensho pushed a commit to Tensho/sidekiq that referenced this issue


          sidekiq#4053

85023a5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment