Add CLI Run Test - Write Pid, System Boot, Print Banner

[Tensho]

I tried to cover as much as I can in #run method with these changes. I'm still thinking how to test daemonized version...

Refactgoring

• Extract Sidekiq::CLI#launch method to detach actual launcher start from the system preparations (write pid, boot system, print banner) to test in isolation
• Cleanup test helper

Improvements

• Add ultra-simple Rails application to spec/dummy for the Sidekiq::Rails engine integration test
• Add appraisal to test sidekiq integration with different rails versions (ATM 4 and 5). Appraisals may be used to test either different versions of the sidekiq dependencies in the future.
• Add minitest-focus
• Add minitest-reporters for convenient work with the tests in RubyMine
• Group gems in bundle

Related PRs

• Cleanup CLI #4026

[mperham]

Don't got overboard on test coverage. The code doesn't change often and it's far easier to test manually once than to construct and maintain some really complicated test harness.

[Tensho]

I just try to understand the code and learn that way, but generally I agree ^_^

[Tensho]

@mperham Are you comfortable with "appraisals" presence?

[mperham]

For now, sure. I will remove it if it becomes a problem.

[Tensho]

@mperham Please let me know if you are fine with the current changes and commits history 🙇

[mperham]

I don't want the test suite to use the default Redis localhost:6379/0

[Tensho]

OK, I may return back

ENV['REDIS_URL'] ||= 'redis://localhost/15'

or without customisation oportunity

ENV['REDIS_URL'] = 'redis://localhost/15'

That should be enough I guess. BTW, why 15? Is it kind of virtual host in RabbitMQ?

[Tensho]

Don't want to be a dick, but we already have tests which rely on default Redis host ^_^
https://github.com/mperham/sidekiq/blob/master/test/test_redis_connection.rb#L84
https://github.com/mperham/sidekiq/blob/master/test/test_redis_connection.rb#L126

[mperham]

Oops, yeah, I want people's default redis database to be untouched by Sidekiq's test suite. We'll need to fix those tests (or make them read only)

[Tensho]

Already done this, Mike ^_^

[Tensho]

@mperham Set REDIS_URL env var to redis://localhost/15 in test environment in ea48409

[Tensho]

@mperham Addressed all your concerns I think. Let me know if there's anything else you can think of.

[mperham]

Thank you for this! I will add a changelog entry to give you credit.

[Tensho]

@mperham Thank you 🙇 It's worth to note about ./test/dummy ultra-simple test Rails app somewhere (README, CONTRIBUTING), so other people don't mess with ./myapp one. It took me a while to understand myapp purpose is for manual testing (it has it's own dependencies declaration in Gemfile), not auto tests.