Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default shutdown timeout #3968

Closed
mperham opened this issue Sep 17, 2018 · 0 comments
Closed

Bump default shutdown timeout #3968

mperham opened this issue Sep 17, 2018 · 0 comments

Comments

@mperham
Copy link
Collaborator

mperham commented Sep 17, 2018

The default shutdown timeout has been 8 seconds since forever. This value was based on Heroku's 10 second process timeout -- worker and web dynos had 10 seconds to shutdown before Heroku would send SIGKILL to kill them without warning.

18 months ago, Heroku extended that timeout to 30 seconds and a year ago I started recommending that people use -t 25 to use most of that window so their jobs have as much time as possible to finish before shutdown (the other 5 seconds is used to push lingering jobs back to Redis before actually exiting).

AWS's ECS also has a 30 second timeout:

https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_StopTask.html

Now I think it is time to update the default from 8 sec to 25 sec to make this move official and allow new apps and users to take advantage of the more recent standard automatically.

Questions? Concerns? Ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants