Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Redis-rb 3.3.4+ #3617

Closed
mperham opened this issue Sep 28, 2017 · 0 comments
Closed

Upgrade to Redis-rb 3.3.4+ #3617

mperham opened this issue Sep 28, 2017 · 0 comments

Comments

@mperham
Copy link
Collaborator

mperham commented Sep 28, 2017

The latest version has Redis#connection which we need to get connection details and avoid using the deprecated client method.

jeremy added a commit to jeremy/sidekiq that referenced this issue Sep 29, 2017
* Loosen Redis version dep to `>= 3.3.5, < 5`
* Bump redis-namespace for looser Redis version dep. Pending
  resque/redis-namespace#136 gem release.

Use `redis.connection` where we can and fall back to `redis._client`
where we need (to inspect timeout and scheme).

References sidekiq#3617
jeremy added a commit to jeremy/sidekiq that referenced this issue Sep 29, 2017
* Loosen Redis version dep to `>= 3.3.5, < 5`
* Bump redis-namespace for looser Redis version dep. Pending
  resque/redis-namespace#136 gem release.

Use `redis.connection` where we can and fall back to `redis._client`
where we need (to inspect timeout and scheme).

References sidekiq#3617
mperham pushed a commit that referenced this issue Sep 29, 2017
* Loosen Redis version dep to `>= 3.3.5, < 5`
* Bump redis-namespace for looser Redis version dep. Pending
  resque/redis-namespace#136 gem release.

Use `redis.connection` where we can and fall back to `redis._client`
where we need (to inspect timeout and scheme).

References #3617
@mperham mperham mentioned this issue Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant