Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument forwarding in Ruby 2.7 #149

Merged
merged 1 commit into from Apr 13, 2021

Conversation

qnighy
Copy link
Contributor

@qnighy qnighy commented Apr 13, 2021

Fixes #148.

In Ruby 2.7 keyword arguments are not yet separated from positional ones. **kwargs was seemingly introduced here to suppress warnings, but for accuracy we need to remove **kwargs and just add ruby2_keywords.

@mperham mperham merged commit 97b2698 into mperham:master Apr 13, 2021
@qnighy qnighy deleted the fix-argument-forwarding branch April 14, 2021 02:02
@qnighy
Copy link
Contributor Author

qnighy commented Apr 14, 2021

Thanks for the quick merge! A patch release would be helpful.

@mperham
Copy link
Owner

mperham commented Apr 14, 2021 via email

@mperham
Copy link
Owner

mperham commented Apr 14, 2021

Done.

@qnighy
Copy link
Contributor Author

qnighy commented Apr 14, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inaccurate proxy behavior when a hash with String and Symbol keys is passed
2 participants