Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor exceptions #130

Closed
mperham opened this issue Jun 2, 2020 · 0 comments
Closed

Refactor exceptions #130

mperham opened this issue Jun 2, 2020 · 0 comments

Comments

@mperham
Copy link
Owner

mperham commented Jun 2, 2020

Pool currently throws Timeout::Error. Refactor to be ConnectionPool::TimeoutError > Timeout::Error so callers can distinguish between a pool timeout and a timeout from a pooled network client.

ConnectionPool::PoolShuttingDownError is a RuntimeError. Make it a subclass of ConnectionPool::Error.
@mperham mperham closed this as completed in dd5dac5 Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mperham