Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to explicitly mention this polyfill is meant to act as a no-op on Safari as it does on Firefox #302

Open
rpl opened this issue Apr 13, 2021 · 0 comments

Comments

@rpl
Copy link
Member

rpl commented Apr 13, 2021

Given that we got some issues filed related to Safari (e.g #234 and #299) it may be good to update README.md#supported-browsers to explicitly mention that:

  • Safari does provide its own natively implemented Promise-based extensions APIs
  • and this polyfill is meant to act as a no-op on Safari (as it does on Firefox).

It may also be reasonable to mention in README.md#known-limitations-and-incompatibilities some known incompatibilities (e.g. I recall that browser.runtime.onMessage.addListener may not be working as in the Firefox promised API when a listener does return a promises, but we'll need to double-check that before mentioning it explicilty)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant