chore(deps): update win orb to v2

[renovate]

This PR contains the following updates:

Package	Type	Update	Change
win	orb	major	1.1.0 -> 2.4.0

---

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box.

---

This PR has been generated by WhiteSource Renovate. View repository job log here.

[rpl]

Based on a quick look to the previous and last version of the circli ci windows orb:

• https://circleci.com/developer/orbs/orb/circleci/windows?version=2.4.0
• https://circleci.com/developer/orbs/orb/circleci/windows?version=1.1.0

It looks that the vs2019 executor has been renamed to default (which also match the error triggered on the CI job by this PR)

Before merging this PR we will have to update the circle ci config accordingly.

[rpl]

TODO:

• investigate test failure on executing test.lib.imports.js on the circle ci windows workers after updating to the new win-2.4.0 circle-ci orb

---

Update (2021/06/07):

• I've been able to reproduce the same issue locally on nodejs v12.11.1, but it isn't triggered in a more recent version of the nodejs old lts (e.g. 12.22.1 which is currently the last release for the old lts).
• my guess is that it wasn't failing on the previous version of the circleci windows orb just because the nodejs version shipped by default didn't also not have that issue
• the updated version of this PR does update the nodejs version used in the windows circleci worker to the last version of the old nodejs lts version

---

Initial analysis (2021/06/01):

Unfortunately the changes described in #2221 (comment) are enough to make fix the circleci config, but that is revealing a odd issue with the test.lib.imports.js test, which is currently failing with the following error message:

  1) web-ext imported as a library
       can be imported as an ESM module:
     Error: Command failed: C:\PROGRAM FILES\NODEJS\NODE.EXE --experimental-modules test-import.mjs
(node:4088) ExperimentalWarning: The ESM module loader is experimental.
internal/modules/esm/default_resolve.js:79
  let url = moduleWrapResolve(specifier, parentURL);
            ^

Error: Cannot resolve package exports target 'undefined' matched for '.' in C:\Users\circleci\AppData\Local\Temp\tmp-web-ext--1292-9mSJuTrSz5zf\node_modules\web-ext\package.json, imported from C:\Users\circleci\AppData\Local\Temp\tmp-web-ext--1292-9mSJuTrSz5zf\test-import.mjs
    at Loader.resolve [as _resolve] (internal/modules/esm/default_resolve.js:79:13)
    at Loader.resolve (internal/modules/esm/loader.js:73:33)
    at Loader.getModuleJob (internal/modules/esm/loader.js:152:40)
    at ModuleWrap.<anonymous> (internal/modules/esm/module_job.js:43:40)
    at link (internal/modules/esm/module_job.js:42:36) {
  code: 'ERR_MODULE_NOT_FOUND'

(link to the entire logs)

[codecov]

Codecov Report

Merging #2221 (044bb4f) into master (82e94d1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2221   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          32       32           
  Lines        1699     1699           
=======================================
  Hits         1697     1697           
  Misses          2        2           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e94d1...044bb4f. Read the comment docs.

[rpl]

@Rob--W I was investigating this issue right before going on PTO last week, but after fixing the original issue I did trigger another one. I took a more deeper look today and updated this PR with a fix (the issue and fix are described in #2221 (comment)).

I plan to merge this soon, do you want to take a quick look first? (mainly in terms of getting a second opinion about the readability and maintainability of the fix applied to the circleci config file, there isn't much to review in this PR besides that).

[Rob--W]

Can you be more explicit about the broken/fixed versions? And add the explicit sentence "Install a recent version without this issue." (Change "recent" to something more accurate if needed)

And if you think that it helps, also include a link to this PR/comment.

[rpl]

I've been a bit lazy, and so I didn't run a bisect, but in the end it would be nice to write down what was the broken range while I'm still around this issue.

Based on a quick bisect, the range between 12.11.1 and 12.15.0 (included) is broken, the first version to work as expected is v12.16.0.

I updated the comment accordingly, but I didn't looked for the first version broken, I don't think we care too much about that in the end.