Skip to content

fix: use getRoot request to support Firefox 77+ #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented Apr 20, 2020

Fixes #1884.

@coveralls
Copy link

coveralls commented Apr 20, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 5e89238 on Rob--W:firefox-remote-77-listTabs-to-getRoot into e0d4c3c on mozilla:master.

@Rob--W Rob--W force-pushed the firefox-remote-77-listTabs-to-getRoot branch from 63165a9 to afd4a9b Compare April 20, 2020 01:38
@willdurand
Copy link
Member

ha well, I was also working on that issue.. I guess I can move on something else now :)

Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm, just a couple of small optional nits.

@rpl
Copy link
Member

rpl commented Apr 20, 2020

ha well, I was also working on that issue.. I guess I can move on something else now :)

ouch, I'm so sorry @willdurand. I'm the one to blame, there was an assigned comment in our shared triaging meeting document but (to make sure that it couldn't be missed) I should have explicitly assigned you the issue and added a comment to mention that you were going to prepare a pull request for it by today or tomorrow.

@Rob--W Rob--W force-pushed the firefox-remote-77-listTabs-to-getRoot branch from afd4a9b to 5e89238 Compare April 20, 2020 12:13
@0c0w3
Copy link

0c0w3 commented Apr 22, 2020

Can this be merged soon? It's making it hard for me to develop an add-on against an m-c build with patches applied. (I'm on the urlbar team and I'm developing a urlbar WebExtensions API.)

@rehandalal
Copy link

Can this be merged soon?

+1 - it's interfering with our work on the experiments infrastructure team as well.

@rpl
Copy link
Member

rpl commented Apr 22, 2020

Can this be merged soon? It's making it hard for me to develop an add-on against an m-c build with patches applied. (I'm on the urlbar team and I'm developing a urlbar WebExtensions API.)

@0c0w3 @rehandalal sure, I plan to merge this today and we should also be able to release it on npm as well.

@0c0w3
Copy link

0c0w3 commented Apr 22, 2020

Thanks! (Thanks for web-ext too, it's nice.)

@rpl rpl merged commit b1b2804 into mozilla:master Apr 22, 2020
@rpl
Copy link
Member

rpl commented Apr 22, 2020

@0c0w3 @rehandalal this has been just released on npm as v4.2.0 (See release notes to know which other changes are included in the new version along with this fix).

Let us know if any other issue in the newly released version is still blocking you.

@rehandalal
Copy link

@rpl thanks for the release! it's working great for me on Ubuntu but my teammate is having an unrelated issue with this release and Nightly on MacOS that is a complete blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web-ext run cannot install a temporary add-on with FF Nightly (build >= 2020-04-14)
6 participants