-
Notifications
You must be signed in to change notification settings - Fork 357
fix: use getRoot request to support Firefox 77+ #1886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use getRoot request to support Firefox 77+ #1886
Conversation
63165a9
to
afd4a9b
Compare
ha well, I was also working on that issue.. I guess I can move on something else now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 lgtm, just a couple of small optional nits.
ouch, I'm so sorry @willdurand. I'm the one to blame, there was an assigned comment in our shared triaging meeting document but (to make sure that it couldn't be missed) I should have explicitly assigned you the issue and added a comment to mention that you were going to prepare a pull request for it by today or tomorrow. |
afd4a9b
to
5e89238
Compare
Can this be merged soon? It's making it hard for me to develop an add-on against an m-c build with patches applied. (I'm on the urlbar team and I'm developing a urlbar WebExtensions API.) |
+1 - it's interfering with our work on the experiments infrastructure team as well. |
@0c0w3 @rehandalal sure, I plan to merge this today and we should also be able to release it on npm as well. |
Thanks! (Thanks for web-ext too, it's nice.) |
@0c0w3 @rehandalal this has been just released on npm as v4.2.0 (See release notes to know which other changes are included in the new version along with this fix). Let us know if any other issue in the newly released version is still blocking you. |
@rpl thanks for the release! it's working great for me on Ubuntu but my teammate is having an unrelated issue with this release and Nightly on MacOS that is a complete blocker. |
Fixes #1884.
getRoot
becauselistTabs
was removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1618691getRoot
is supported since Firefox 55, with https://bugzilla.mozilla.org/show_bug.cgi?id=1352157getList
fallback to not unnecessarily breaking backwards compatibility, so this is a safe patch for a minor release.