Skip to content

fix: Remove WEB_EXT_* env vars not supported by the selected web-ext command #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

rpl
Copy link
Member

@rpl rpl commented Jan 10, 2020

This PR contains another possible approach to fix #793 (as an alternative to disabling the yargs strict parsing as in #1810 )

  • add new unit tests to cover the changes (and fix coveralls failure due to decreased code coverage)
  • add an integration test (to make sure the fix does work as expected when the options and environment vars are actually parsed and validated by yargs).

Sorry, something went wrong.

@coveralls
Copy link

coveralls commented Jan 10, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 18f2118 on rpl:fix/yargs-env-vars-parsing-issue into 333b29b on mozilla:master.

@rpl rpl force-pushed the fix/yargs-env-vars-parsing-issue branch from 6313e09 to d327b9a Compare January 10, 2020 11:14
@rpl rpl changed the title fix: Remove WEB_EXT_* env vars not supported to the current command fix: Remove WEB_EXT_* env vars not supported by the selected web-ext command Jan 10, 2020
@rpl rpl force-pushed the fix/yargs-env-vars-parsing-issue branch from 55a0344 to 18f2118 Compare January 10, 2020 16:47
@rpl
Copy link
Member Author

rpl commented Jan 10, 2020

@Rob--W this PR has rebased on top of #1813 and the tests still pass as expected.

should be ready for one last look

@rpl rpl merged commit e585740 into mozilla:master Jan 13, 2020
@apiraino
Copy link

thanks @rpl ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment variables get applied as options to any command
4 participants