Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken in Node.js v18. #454

Closed
Qard opened this issue Apr 23, 2022 · 3 comments
Closed

Broken in Node.js v18. #454

Qard opened this issue Apr 23, 2022 · 3 comments

Comments

@Qard
Copy link

Qard commented Apr 23, 2022

Apparently this module environment detects the browser by looking for the "fetch" function but fetch is now available in Node.js v18. It no longer works in Node.js because it thinks it's a browser. 馃槓
@devinivy devinivy mentioned this issue Apr 23, 2022
Merged
This was referenced Apr 24, 2022
Merged
Merged
@maxmilton
Copy link

maxmilton commented Apr 24, 2022 •
edited

Reading through terser/terser#1164 it seems Node.js detection was already fixed years ago back in 2018 but never released. Looks like issue #452 is about publishing a new release.

arneg added a commit to DeutscheSoft/aes70explorer that referenced this issue Apr 28, 2022
@arneg
[npm]: Manually add terser 5.13.0 dependency
6c8d449 
This updates the source-maps package which is broken in NodeJS 18 and
above:

mozilla/source-map#454
This was referenced Apr 29, 2022
Open
Merged
Merged
@LekoArts LekoArts mentioned this issue May 9, 2022
Closed
2 tasks
@egoist egoist mentioned this issue May 16, 2022
Closed
egoist pushed a commit to egoist/tsup that referenced this issue May 16, 2022
fix: update source-map to 0.8.0-beta.0, closes #623
c67e03d 
the `source-map` package is broken in Node.js 18, it was fixed but the beta version was never released

see mozilla/source-map#454
@3cp 3cp mentioned this issue May 17, 2022
Merged
@jacobq
Copy link

jacobq commented May 17, 2022

Duplicate of #432 / #452

@maniator maniator mentioned this issue May 31, 2022
Open
@aeisenberg aeisenberg mentioned this issue Jun 3, 2022
Closed
@eemeli
Copy link
Member

eemeli commented Jun 6, 2022

This is fixed in source-map@0.7.4.

@eemeli eemeli closed this as completed Jun 6, 2022
oetiker added a commit to qooxdoo/qooxdoo that referenced this issue Jun 27, 2022
@oetiker
Make source-map compatibe with node v18
b40295f 
It seems only source-map 0.7.4 works with node v18: mozilla/source-map#454
@oetiker oetiker mentioned this issue Jun 27, 2022
Merged
hkollmann pushed a commit to qooxdoo/qooxdoo that referenced this issue Jun 28, 2022
@oetiker
Make source-map compatibe with node v18 (#10418)
a650b6b 
It seems only source-map 0.7.4 works with node v18: mozilla/source-map#454

Thanks @oetiker !
@Bowen7 Bowen7 mentioned this issue Sep 4, 2022
Closed
@xuesichao xuesichao mentioned this issue Oct 28, 2022
Merged
@sigv sigv mentioned this issue Oct 29, 2022
Closed
heypiotr added a commit to heypiotr/ncc that referenced this issue Nov 8, 2022
@heypiotr
Update source-map used by Terser to 0.7.4
7db0609 
Fixes minification failing on Node 18 with:

You must provide the URL of lib/mappings.wasm by calling SourceMapConsumer.initialize({
'lib/mappings.wasm': ... }) before using SourceMapConsumer

mozilla/source-map#454
@heypiotr heypiotr mentioned this issue Nov 8, 2022
Merged
@jennifermarsman jennifermarsman mentioned this issue Nov 18, 2022
Merged
styfle pushed a commit to vercel/ncc that referenced this issue Nov 27, 2022
@heypiotr
fix: node 18 by update source-map used by Terser to 0.7.4 (#999)
2f69f83 
Fixes minification failing on Node 18 with:

> You must provide the URL of lib/mappings.wasm by calling
SourceMapConsumer.initialize({ 'lib/mappings.wasm': ... }) before using
SourceMapConsumer

mozilla/source-map#454

There's also an open dependabot PR to bump the Terser version itself, I
confirmed that also fixes the issue:
[chore(deps-dev): bump terser from 5.10.0 to
5.15.1](#988)
@beurkinger beurkinger mentioned this issue Dec 8, 2022
Closed
@claviska claviska mentioned this issue Jan 9, 2023
Closed
SeanZellmer added a commit to SeanZellmer/tsup that referenced this issue Feb 16, 2023
@SeanZellmer
fix: update source-map to 0.8.0-beta.0, closes #623
719b952 
the `source-map` package is broken in Node.js 18, it was fixed but the beta version was never released

see mozilla/source-map#454
@muratcorlu muratcorlu mentioned this issue Mar 24, 2023
Closed
@CuddleBunny CuddleBunny mentioned this issue Apr 18, 2023
Closed
This was referenced May 5, 2023
Closed
Merged
@mikaello mikaello mentioned this issue May 14, 2023
Open
matheusccastroo added a commit to matheusccastroo/meteor that referenced this issue Jun 2, 2023
@matheusccastroo
Update Node version to 18.16.0 LTS
a112ad5 
Bump the `source-map` version to fix the issue: mozilla/source-map#454.

We are not updating the NPM version because there is an breaking change with the `npm config set python` which we use with `node-gyp`.
@ahammond ahammond mentioned this issue Oct 12, 2023
Merged
diracdeltas added a commit to brave/brave-core that referenced this issue Oct 17, 2023
@diracdeltas
Workaround source-map issue in Node 18
041e4f1 
Workaround for mozilla/source-map#454 since we
seem to be hitting this error, causing jest reporting to fail.
diracdeltas added a commit to brave/brave-core that referenced this issue Oct 17, 2023
@diracdeltas
Workaround source-map issue in Node 18
daac6ed 
Workaround for mozilla/source-map#454 since we
seem to be hitting this error, causing jest reporting to fail.
diracdeltas added a commit to brave/brave-core that referenced this issue Oct 17, 2023
@diracdeltas
Workaround source-map issue in Node 18
e3b1497 
Workaround for mozilla/source-map#454 since we
seem to be hitting this error, causing jest reporting to fail.

cross-env is needed to make env variable setting work on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Qard @eemeli @jacobq @maxmilton