Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring all Rhino docs under version control and host on GitHub Pages #954

Closed
p-bakker opened this issue Jun 25, 2021 · 27 comments
Closed

Bring all Rhino docs under version control and host on GitHub Pages #954

p-bakker opened this issue Jun 25, 2021 · 27 comments
Labels
docs Issues containing stuff that ought to be documented

Comments

@p-bakker
Copy link
Collaborator

Currently we don't use the Github Wiki functionality and some of the links in our README point to archived pages on developer.mozilla.org

It looks like an attempt was made to move that content to Github Pages, but it looks like that effort isn't up to date and keeping it up to date is more effort then when the content would be in the project wiki

So I propose to enable the Wiki, move the content that is currently on developer.mozilla.org and/or our Github Pages there and then remove the documentation content from our Github Pages and update the links in our README's to point to our Wiki.

The only thing that might still be hosted on our Github page could be the Rhino JavaDocs, but those seem out of date (v1.7.11 currently). The compat tables from there can be tossed I think as Rhino is now included in https://kangax.github.io/compat-table/es6/

@gbrail
Copy link
Collaborator

gbrail commented Jun 28, 2021 via email

@p-bakker
Copy link
Collaborator Author

Great, think you'll have to enable the wiki and then we're off to the races 🙂

@tonygermano
Copy link
Contributor

I'd actually suggest continuing to use the gh-pages (which I wasn't aware existed before now) and point the links there. Github's wikis kind of suck. They rightfully can only be edited by collaborators by default, and I don't think you'd want to make it public.

You can accept PRs for gh-pages from anyone, but not for the wiki.

@tonygermano
Copy link
Contributor

tonygermano commented Jun 28, 2021

On the topic of github features, though, Discussions might be something useful to turn on. It's something like a poor StackOverflow clone. It would actually be a more appropriate place to have discussions like this than on an issue until a decision was made. It could also replace be an alternative to the mailing list and be a place for people to ask questions related to the use of Rhino that aren't actually issues.

@gbrail
Copy link
Collaborator

gbrail commented Jun 28, 2021 via email

@p-bakker
Copy link
Collaborator Author

I'd actually suggest continuing to use the gh-pages (which I wasn't aware existed before now) and point the links there. Github's wikis kind of suck. They rightfully can only be edited by collaborators by default, and I don't think you'd want to make it public.

Mmm, wasnt aware of that. Did some research and there are ways to accept PR's on wiki content, but its cumbersome: the wiki is it's own git repo, but doesn't come with the bells and whistles that project repo's come with, like PR's or forking. But you can manually clone them, to work on them offline or to put them in a regular project repo, so you can have PR's on them (but you'd have to sync that copy with the original wiki repo somehow). All in all not straight-forward...

The alternative, gh-pages, I'm not very familiar with, so I'll dig in a bit. Wanna be able to use markdown, instead of having to handcode HTML, nor do I think it would be nice that you'd need to install a bunch of extra tooling locally. A quick tests seems to suggest you can just put markdown files in the hg-pages branch and it'll render them as HTMl.

Will keep you posted

@p-bakker
Copy link
Collaborator Author

p-bakker commented Jul 1, 2021

k, got something going :-) Found a theme for Github Pages that does most of the heavy lifting, allowing us to focus on writing content in MarkDown

Now in the process of setting up a page structure and seeing which content currently on https://developer.mozilla.org/en-US/docs/Mozilla/Projects/Rhino is still relevant

One thing to decide though: currently our Github Pages are sourced from the gh-pages branch, which means switching branches if you want to work on the docs and because it has a completely different folder structure as the master branch, on both sides we'd have to start git ignoring the other's folders, else things are a bit messy.

As far as I can tell, you can also source the content for Github Pages from a folder in any other branch, so we could instead create a docs folder in the master branch and put all the documentation in there. Extra benefit is that if making code changes in master that also require changes to the docs, both can be in the same PR.

Thoughts?

@p-bakker
Copy link
Collaborator Author

p-bakker commented Jul 1, 2021

Check out https://p-bakker.github.io/rhino/ to get an idea where this might be going

@gbrail
Copy link
Collaborator

gbrail commented Jul 1, 2021 via email

@p-bakker
Copy link
Collaborator Author

p-bakker commented Jul 1, 2021

If you go to Settings > Pages, you can select the branch and root folder from which Github Pages sources its content.

Note that you can also enable HTTPS there, which I think we should do

@p-bakker p-bakker changed the title Enable Github Wiki and move documentation to the Wiki Bring all Rhino docs under version control and host on GitHub Pages Jul 6, 2021
@p-bakker p-bakker added the docs Issues containing stuff that ought to be documented label Jul 9, 2021
@C-Masuda
Copy link

C-Masuda commented Jul 19, 2021

Any ETA on this? Right now it looks like Rhino Documentation doesn't exist anywhere... See here. @p-bakker

@p-bakker
Copy link
Collaborator Author

Mmm, didn't know Mozilla took all archived documentation offline...

That changes the priority a bit, as before I was just working on it on and off.

I'll try to get the basic scaffolding up in a PR asap, but that will probably be a few weeks. After that, there will probably be a lot of pages that still need to be petted over and/or (re)written, but others could then chip in

@p-bakker
Copy link
Collaborator Author

Note: the source of all Rhino documentation that was available on MDN but has now been removed can be found here: https://github.com/mdn/archived-content/tree/main/files/en-us/mozilla/projects/rhino

@p-bakker
Copy link
Collaborator Author

Note: we can submit a PR to https://github.com/mdn/yari to get all the old MDN url's to redirect to our new documentations (once it's available), see mdn/yari#3323 (comment)

@p-bakker
Copy link
Collaborator Author

p-bakker commented Jul 26, 2021

Do we care about keeping RELEASE-NOTES.md? It's basically a duplicate of all the info already recorded on all the releases in GitHub itself.

@peterharaszin
Copy link

I would also suggest updating the link in the official README.md file:
https://github.com/mozilla/rhino/blob/master/README.md
image

Thanks in advance!

@p-bakker p-bakker added this to the Release 1.7.15 milestone Oct 14, 2021
@p-bakker p-bakker added this to To do in v1.7.xx Oct 14, 2021
@p-bakker p-bakker moved this from To do to In progress in v1.7.xx Oct 14, 2021
@p-bakker p-bakker added this to In progress in documentation Oct 14, 2021
@p-bakker p-bakker removed this from In progress in v1.7.xx Oct 14, 2021
@p-bakker
Copy link
Collaborator Author

Quick update: check out https://p-bakker.github.io/rhino/

Still mostly the old content and want to clean up a bit more before I cretae the PR:

Any comments welcome

@p-bakker
Copy link
Collaborator Author

p-bakker commented Dec 9, 2021

Does anyone know about optLevels in Rhino? See #1123 for a question I have about it

@andrewloutfi
Copy link

Seeing the link under "More resources if you get stuck" in the README resolving to a 404 page.

Might be worth running a tool like markdown-link-check over the repo.

Screen Shot 2022-01-16 at 8 21 18 AM

@reviewher
Copy link

The link in the sidebar https://www.mozilla.org/rhino/ points to a nonexistent website.

@p-bakker even if it is not 100%, https://p-bakker.github.io/rhino/ is a far better resource than the 404 page on the Mozilla site.

@p-bakker
Copy link
Collaborator Author

p-bakker commented Oct 5, 2023

@gbrail I've taken my https://github.com/p-bakker/rhino/tree/docs_on_the_move branch (from which the https://p-bakker.github.io/rhino/ Github Page is sourced) and extracted the contents (and history) of just the docs folder to a new repo: https://github.com/rhino/rhino.github.io

So now we have what was before just hosted on my personal fork also on https://rhino.github.io/

I think we should change website in the About section on this repo to point to https://rhino.github.io/ instead of https://www.mozilla.org/rhino/ and then toss out the entire /docs/ folder in this repo and update the link to the archived page in https://github.com/mozilla/rhino#documentation

Think having all the docs in a separate repo will be better going forward

@p-bakker
Copy link
Collaborator Author

p-bakker commented Oct 5, 2023

Just to be clear: what is up at https://rhino.github.io/ / https://p-bakker.github.io/rhino/ leaves much to be desired, but it's better than nothing and at least no that its in a (non-personal) repo, others could contribute

@p-bakker
Copy link
Collaborator Author

@gbrail could you change the https://www.mozilla.org/rhino/ link in the about section of this repo to point to https://rhino.github.io/ instead?

@p-bakker
Copy link
Collaborator Author

@gbrail any update on the above? Or don't you think we should do this?

@gbrail
Copy link
Collaborator

gbrail commented May 14, 2024 via email

@gbrail
Copy link
Collaborator

gbrail commented May 20, 2024 via email

@p-bakker p-bakker removed this from the Release 1.7.15 milestone May 21, 2024
@p-bakker
Copy link
Collaborator Author

Closing as rhino.github.io is now live with all the old documentation what was previously hosted on mozilla.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues containing stuff that ought to be documented
Projects
documentation
In progress
Development

No branches or pull requests

7 participants